/---------------------------------------\ | Feed back on Mandatory assignment II: | \---------------------------------------/ Handed in by Kenn Thisted Corrected by Rasmus Lerchedahl Petersen Part A: ------ Structural test 1: - It is good that you write down the assumption. - It is nice that you have labelled the choices. - * You have correctly made sure, that the input used to branch in choice 2 (the first nested if-construct) validates choice 1 (the outer if-construct). * You do, however, reuse input validating choice 1 to test choices 3 and 4. This will not work since the function is sure to return before it leaves the first if-block. The if-block at choice 3 will then never be executed. * In particular dataset A and D can not be used to test choices 3 and 3. - It is good practice that you use different input in the different datasets. Structural Test 2: - Use Y' in the test as a seperate case. (Yes, here) - The property "x >= y and not eval." does not make sense. I would much rather see "x >= y and y = least(y,z)". This would make it clear what the input might look like. I hope this answers the question (missing link from a,b to m in y,z or x,z format - how to show properly?) - Actually, I would prefer not to mention a and b when testing the second function. Functional Test: - Sound choice of classes, in particular you have all combinations of High, Low and Middle. - It is good to include MaxInt and MinInt. Having done this, though, you might like to include a case i which one of the two would become the expected output. - It is good to test for negative numbers. One might like not to mx this test up with MaxInt and MinInt, though. Part B: ------ - Your program runs, and the testing is reasonable. Conclusion: ---------- The assignment is PASSED.